Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding 3 loop types for connector #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adding 3 loop types for connector #28

wants to merge 2 commits into from

Conversation

nicolasmagalhaes
Copy link
Member

Adicionei os loops ao tables connector :foward, :backward e :yoyo como parametro no TablesConnector e o parametro padrao é :none que nao realiza nenhum tipo de loop

@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #28 into master will increase coverage by 2.48%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   32.06%   34.54%   +2.48%     
==========================================
  Files           8        8              
  Lines         131      165      +34     
==========================================
+ Hits           42       57      +15     
- Misses         89      108      +19
Impacted Files Coverage Δ
src/connector.jl 44.64% <43.75%> (-10.92%) ⬇️
src/stream.jl 82.85% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab85f41...cc6a8ac. Read the comment docs.

@nicolasmagalhaes nicolasmagalhaes linked an issue Sep 2, 2020 that may be closed by this pull request
Possibilidade de Loop no conector TablesConector #24
Open
@nicolasmagalhaes nicolasmagalhaes added enhancement New feature or request good first issue Good for newcomers labels Sep 2, 2020
@Conradox
Copy link
Collaborator

Conradox commented Sep 2, 2020

Posso estar enganado, mas acho que um melhor jeito de implementar isso seria a partir do uso do multiple dispatch oferecido pela linguagem, deixando para o interpretador a tarefa de cambiar entre as rotinas de acordo com o tipo de tabela usada na função EasySteam.next.

@Conradox
Copy link
Collaborator

Conradox commented Sep 2, 2020

Um fator também importante seria a adição de testes para está funcionalidade.

@nicolasmagalhaes
Copy link
Member Author

Um fator também importante seria a adição de testes para está funcionalidade.

sim sim os testes eu vou colocar quando o review estiver certinho

@nicolasmagalhaes
Using Multiple Dispatch
cc6a8ac 
Altered the way loops are read by using multiple dispatch
@nicolasmagalhaes
Copy link
Member Author

modifiquei para usar o Multiple Dispatch

@nicolasmagalhaes nicolasmagalhaes changed the title adding 3 loop types for connector :foward :backward :yoyo adding 3 loop types for connector Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipebraida filipebraida Awaiting requested review from filipebraida

@Conradox Conradox Awaiting requested review from Conradox

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibilidade de Loop no conector TablesConector
2 participants
@nicolasmagalhaes @Conradox